The jsonrpcclient.py file has two instances of generic exception handling. Generic exception handling breaks PEP 8 and can make debugging issues more difficult, especially since exceptions are suppressed.
Although we are logging exceptions, I recommend re-working this logic. If we choose to keep generic exception handling then we may at least consider simplifying instances of redundant code where repeat logic is used across different exceptions.
The
jsonrpcclient.pyfile has two instances of generic exception handling. Generic exception handling breaks PEP 8 and can make debugging issues more difficult, especially since exceptions are suppressed.Although we are logging exceptions, I recommend re-working this logic. If we choose to keep generic exception handling then we may at least consider simplifying instances of redundant code where repeat logic is used across different exceptions.