search

dbcli / mssql-cli

A command-line client for SQL Server with auto-completion and syntax highlighting
BSD 3-Clause "New" or "Revised" License
1.35k stars 191 forks source link

PEP 8 changes #351

Closed ellbosch closed 4 years ago

ellbosch commented 4 years ago

Tag: #283.

Looks like there's quite a few files I missed for PEP 8 changes. Rather than submit 1 giant PR, I will send out smaller ones.

The biggest change here is to generatequerybaseline.py. The id keyword was renamed to request_id since Python already has a built-in id variable. This impacted a few files leveraging these methods, since the keywords (if used) needed to be renamed.

kevcunnane commented 4 years ago

Is the failed test flaky? Any idea the cause?

ellbosch commented 4 years ago

Is the failed test flaky? Any idea the cause?

Flaky test. I need to investigate this further.

ellbosch commented 4 years ago

The build failure is the result of a connection timeout on a query. This is the first time this test has failed on a network error, and has been stable for some time. I'll watch this closely.