JSON RPC request class refactor

dbcli / mssql-cli

A command-line client for SQL Server with auto-completion and syntax highlighting

BSD 3-Clause "New" or "Revised" License

1.36k stars 191 forks source link

JSON RPC request class refactor #361

Closed ellbosch closed 4 years ago

ellbosch commented 4 years ago

Closes #358.

This PR fixes an issue regarding redundant code leveraging the Request class. I was able to consolidate functionality inside Request which simplified any subclasses leveraging the parent class. 40 lines of code were eliminated with this change.

ellbosch commented 4 years ago

Closing until the other active PR is merged.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert and fixes 1 when merging afbbf73f17fc7ce647bed940d0ca123a6fbc0114 into 9cb84e21ac50f2082c1c136780b674cb35a0c5d8 - view on LGTM.com

new alerts:

1 for Unmatchable dollar in regular expression

fixed alerts:

1 for Wrong number of arguments for format