Create source distributions on macOS during build

dbcli / mssql-cli

A command-line client for SQL Server with auto-completion and syntax highlighting

BSD 3-Clause "New" or "Revised" License

1.35k stars 191 forks source link

Create source distributions on macOS during build #384

Closed ellbosch closed 4 years ago

ellbosch commented 4 years ago

Closes #322.

This PR adds support for creating gztar and zip source distributions. The sdist call is made during the build phase, which is also when wheel files are created.

Furthermore, I added a check to only call sdist if the platform is macOS. This is because unlike wheel files, it is not required to generate source distributions on every platform we wish to support*, since we can generate both the gztar and zip from macOS.

*I need to test this hypothesis :)

chlafreniere commented 4 years ago

Please make sure the checks pass 😄

ellbosch commented 4 years ago

@chlafreniere: a few changes made since our meeting yesterday:

zip file option removed (in favor of targz) since only one sdist can be supported
minor changes to variable names to make things clearer
version bump