dbcli / mssql-cli

A command-line client for SQL Server with auto-completion and syntax highlighting
BSD 3-Clause "New" or "Revised" License
1.35k stars 191 forks source link

Skip telemetry test if opt out policy set to true #413

Closed ellbosch closed 4 years ago

ellbosch commented 4 years ago

Until recently, our test pipelines in Azure were logging telemetry. We set our opt-out policy to True in an effort to log accurate data to our analytics, but our tests started to fail due to a unit test that checks for a non-empty payload against the telemetry client. When telemetry is turned off, the payload is empty, thus failing the test.

A better solution is needed that properly tests a working telemetry client without logging data or impacting customer privacy. We should revisit this at a later time.