Updated stable download links - Githubissues

dbcli / mssql-cli

A command-line client for SQL Server with auto-completion and syntax highlighting

BSD 3-Clause "New" or "Revised" License

1.35k stars 192 forks source link

Updated stable download links #436

Closed ellbosch closed 4 years ago

ellbosch commented 4 years ago

I've updated links to point at latest stable version number, rather than use 'dev-latest'.

Furthermore, all downloads now point to our daily storage. @pensivebrian please let me know if this is good practice.

ellbosch commented 4 years ago

Stable bits should never point to our storage account - we should link to the official repo.

Unfortunately with regards to PyPI, there's a unique link that's generated for each wheel that's upload. You can see this here. What do you think is the best way to manage direct links to wheels?

ellbosch commented 4 years ago

Need to point links to pypi and packages.microsoft.com.

Here's a thought. What if we just removed all direct links? I just don't see the need to provide this, and also given my comments above on not being able to provide direct links to PyPI.

ellbosch commented 4 years ago

Holding off on this until 1.0 is released.

ellbosch commented 4 years ago

@pensivebrian: my most recent commits update the Linux docs:

Added Ubuntu 18.04 and CentOS 8 instructions
Removed SUSE and Fedora instructions
Added import key step for RPM builds so that the signature warning no longer appears

ellbosch commented 4 years ago

For the install steps, we have the same steps for the other SQL Linux tools which have had a fair amount of testing. I'd like to keep them the same unless there is good reason to diverge.

I had chosen to go off the docs for Packages.Microsoft, but I can change if you prefer SQL Server docs.

RPM instructions appear to be the only difference. SQL Server docs are missing a step to import the key, without which leads to signature warning, so I'll make sure to keep that.