echo_via_pager broken on Windows in 7.1 - Githubissues

dbcli / mssql-cli

A command-line client for SQL Server with auto-completion and syntax highlighting

BSD 3-Clause "New" or "Revised" License

1.35k stars 192 forks source link

echo_via_pager broken on Windows in 7.1 #442

Closed Chadiaw closed 4 years ago

Chadiaw commented 4 years ago

Calls to click.echo_via_pager are failing on Windows since upgrading to 7.1

Expected behavior (7.0)

Python 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 22:22:05) [MSC v.1916 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import click
>>> click.__version__
'7.0'
>>> text = [f"hello {i} \n" for i in range(1000)]
>>> click.echo_via_pager(text)
hello 0
hello 1
hello 2
hello 3
hello 4
-- MORE --

Actual behavior (7.1)

Python 3.8.1 (tags/v3.8.1:1b293b6, Dec 18 2019, 23:11:46) [MSC v.1916 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import click
>>> click.__version__
'7.1.1'
>>> text = [f"hello {i} \n" for i in range(1000)]
>>> click.echo_via_pager(text)
The system cannot find the file specified.
>>>

Notes

Only seems broken on Windows: tested with Ubuntu WSL and click 7.1, works as expected

Chadiaw commented 4 years ago

Closed this since I meant to post the issue in click.