search

dbcli / mssql-cli

A command-line client for SQL Server with auto-completion and syntax highlighting
BSD 3-Clause "New" or "Revised" License
1.35k stars 191 forks source link

Require enum34 only for Python versions before 3.4 #503

Open ts826848 opened 3 years ago

ts826848 commented 3 years ago

enum34 appears to be a potential source of problems when installed in environments using Python 3.4 or later [0, 1]. Apparently enum34 1.1.8 was able to avoid these issues, but a regression was introduced in 1.1.9 and is still present in the most recent release [2].

This commit loosens the requirement on enum34 so that it is only installed if Python 3.3 or older is used.

This particular solution requires setuptools v36.2 or newer [3]. If older versions of setuptools need to be supported, then the requirements can be put into an extras_require clause [4, 5].

[0]: https://github.com/python-poetry/poetry/issues/1122 [1]: https://github.com/iterative/dvc/issues/1995 [2]: https://web.archive.org/web/20200621215937/https://bitbucket.org/stoneleaf/enum34/issues/31/make-the-install-a-noop-on-python36 [3]: https://setuptools.readthedocs.io/en/latest/history.html#v36-2-0 [4]: https://github.com/robshakir/pyangbind/issues/232#issuecomment-437987496 [5]: https://gitlab.com/pycqa/flake8/-/merge_requests/191/diffs

ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

ts826848 commented 3 years ago

In my specific case, I ran into issues compiling a project with Nuitka when mssql-cli was installed in the same virtualenv.