search

dbcli / mssql-cli

A command-line client for SQL Server with auto-completion and syntax highlighting
BSD 3-Clause "New" or "Revised" License
1.35k stars 192 forks source link

[documentation] add docs on port configuration #522

Closed pietdaniel closed 2 years ago

pietdaniel commented 3 years ago

This PR updates the usage_guide.md documentation by adding an example for port configuration. As a non SQLServer user I was unaware of the convention of using HOST,PORT. Without a CLI flag for port it was non obvious to me that a comma in the DB_HOST param was what was expected. Looking at the source here revealed the answer.

In the future perhaps supporting a -O --port argument would be useful, happy to submit a PR if desired.

Newline as added at the end of the file as well.

mdavis-xyz commented 2 years ago

I was just about to write a PR to do this change, and I saw it's already submitted.

What's the status of this PR? It looks approved and passable.