Fix incompatibility with python-click >= 8.1.0 - Githubissues

dbcli / mycli

A Terminal Client for MySQL with AutoCompletion and Syntax Highlighting.

http://mycli.net

Other

11.42k stars 661 forks source link

Fix incompatibility with python-click >= 8.1.0 #1042

Closed Arvind2222 closed 2 years ago

Arvind2222 commented 2 years ago

Fixes 1038 Fixes 1041

Fixes for python-click>= 8.1.0
Change CI VM from Ubuntu 16.04 to 18.04 as Github no longer supports 16.04

Click Deprecation for get_terminal_size() - https://click.palletsprojects.com/en/8.0.x/api/#click.get_terminal_size GitHub Deprecation for Ubuntu 16.04 – https://github.blog/changelog/2021-04-29-github-actions-ubuntu-16-04-lts-virtual-environment-will-be-removed-on-september-20-2021/

Checklist

[x] I've added this contribution to the changelog.md.
[x] I've added my name to the AUTHORS file (or it's already there).

rolandwalker commented 2 years ago

This can't pass CI cleanly and separately because of the very bug in #1038 . All needs to be combined in one PR.

Arvind2222 commented 2 years ago

@rolandwalker

This can't pass CI cleanly and separately because of the very bug in #1038 . All needs to be combined in one PR.

Done !

rolandwalker commented 2 years ago

Looking good. Sorry I rewrote the description since all is included here.