Closed dveeden closed 1 year ago
@amjith these are functions as you can see in the documentation. Is this the right way to add these?
There's a separate variable that keeps a list of functions. https://github.com/dbcli/mycli/blob/main/mycli/sqlcompleter.py#L175
If you see this specific commit (https://github.com/dbcli/mycli/pull/1071/commits/755de1ebd80d744b0542aafc139dd672ed1fef85) you'll see how I added the tidb keywords variable. You might want to do the same for the functions variable.
Base: 67.92% // Head: 67.99% // Increases project coverage by +0.06%
:tada:
Coverage data is based on head (
9a6b274
) compared to base (48bd4c9
). Patch coverage: 39.62% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@amjith is this ok?
@amjith Did you have time to look at this?
Sorry about the delay in reviewing this.
Description
Add the TiDB specific functions as keywords to improve auto completion.
Reference:
Checklist
changelog.md
.AUTHORS
file (or it's already there).