codecov-commenter
commented
2 years ago Codecov Report
Base: 67.92% // Head: 66.59% // Decreases project coverage by -1.32% :warning:
Coverage data is based on head (
660cf45) compared to base (48bd4c9). Patch coverage: 32.05% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1089 +/- ## ========================================== - Coverage 67.92% 66.59% -1.33% ========================================== Files 26 26 Lines 2756 2823 +67 ========================================== + Hits 1872 1880 +8 - Misses 884 943 +59 ``` | [Impacted Files](https://codecov.io/gh/dbcli/mycli/pull/1089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli) | Coverage Δ | | |---|---|---| | [mycli/clitoolbar.py](https://codecov.io/gh/dbcli/mycli/pull/1089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli#diff-bXljbGkvY2xpdG9vbGJhci5weQ==) | `29.62% <0.00%> (-3.71%)` | :arrow_down: | | [mycli/key\_bindings.py](https://codecov.io/gh/dbcli/mycli/pull/1089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli#diff-bXljbGkva2V5X2JpbmRpbmdzLnB5) | `35.13% <20.00%> (-8.87%)` | :arrow_down: | | [mycli/main.py](https://codecov.io/gh/dbcli/mycli/pull/1089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli#diff-bXljbGkvbWFpbi5weQ==) | `63.49% <27.27%> (-1.79%)` | :arrow_down: | | [mycli/packages/completion\_engine.py](https://codecov.io/gh/dbcli/mycli/pull/1089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli#diff-bXljbGkvcGFja2FnZXMvY29tcGxldGlvbl9lbmdpbmUucHk=) | `61.90% <50.00%> (-0.17%)` | :arrow_down: | | [mycli/sqlcompleter.py](https://codecov.io/gh/dbcli/mycli/pull/1089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli#diff-bXljbGkvc3FsY29tcGxldGVyLnB5) | `81.89% <55.55%> (-2.39%)` | :arrow_down: | | [mycli/completion\_refresher.py](https://codecov.io/gh/dbcli/mycli/pull/1089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli#diff-bXljbGkvY29tcGxldGlvbl9yZWZyZXNoZXIucHk=) | `90.00% <80.00%> (-0.91%)` | :arrow_down: | | [mycli/\_\_init\_\_.py](https://codecov.io/gh/dbcli/mycli/pull/1089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli#diff-bXljbGkvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [mycli/config.py](https://codecov.io/gh/dbcli/mycli/pull/1089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli#diff-bXljbGkvY29uZmlnLnB5) | `62.23% <0.00%> (-1.07%)` | :arrow_down: | | ... and [1 more](https://codecov.io/gh/dbcli/mycli/pull/1089/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dbcli):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
lgtm-com[bot]
Description
Fixes #1087 .
I thought this implementation was correct, but I don't use vi-mode, and we have an issue from a user who does. Best to remove the vi bindings. Perhaps someone who uses vi-mode can PR better bindings.
Checklist
changelog.md.AUTHORSfile (or it's already there).