dbcli / mycli

A Terminal Client for MySQL with AutoCompletion and Syntax Highlighting.
http://mycli.net
Other
11.5k stars 664 forks source link

fix SSL through SSH jump #1179

Closed amne closed 3 days ago

amne commented 1 week ago

Description

Attempt to fix https://github.com/dbcli/mycli/issues/1176 The error is caused by paramiko.channel.Channel class that implements a subset of python's socket API and cannot be properly wrapped in SSL because of this.

These changes replace the use of Channel with a straightforward approach of opening a python socket to local bound host and port of a tunnel to the jump host.

Checklist

amjith commented 3 days ago

Thank you for the fix.

amjith commented 2 days ago

@amne Does this need to to go in setup.py as well right here?

amne commented 2 days ago

hi @amjith , I think it should if it helps long-term.