Allow fine-grained customization of Pygments SQL highlighting styles

dbcli / mycli

A Terminal Client for MySQL with AutoCompletion and Syntax Highlighting.

http://mycli.net

Other

11.42k stars 661 forks source link

Allow fine-grained customization of Pygments SQL highlighting styles #922

Closed rolandwalker closed 3 years ago

rolandwalker commented 3 years ago

Description

Allows individual customization of each syntax-highlighting face that the Pygments MySQL lexer can produce.

Doesn't change any behavior by default. The user would have to add/enable entries in ~/.myclirc.

Populates the template ~/.myclirc with commented-out entries matching syntax_style = default.

Checklist

[x] I've added this contribution to the changelog.md.
[x] I've added my name to the AUTHORS file (or it's already there).

amjith commented 3 years ago

I'm usually reluctant to add configuration options that don't provide value. I like the design philosophy of fish shell. https://fishshell.com/docs/current/design.html#configurability-is-the-root-of-all-evil

In this case I'm going to merge this since it doesn't take away from having sensible defaults and syntax coloring is a highly subjective feature.

rolandwalker commented 3 years ago

Thank you for making an exception for this case!

Many of the provided styles don't provide sufficient contrast against a dark background, and certain individual colors need a little readability boost.