Stop editor test from creating file "select" - Githubissues

dbcli / mycli

A Terminal Client for MySQL with AutoCompletion and Syntax Highlighting.

http://mycli.net

Other

11.42k stars 661 forks source link

Stop editor test from creating file "select" #929

Closed rolandwalker closed 3 years ago

rolandwalker commented 3 years ago

Description

open_external_editor() was ignoring the $EDITOR environment variable when $VISUAL was set
the "select" in "select 1" was interpreted as a filename when the string was passed as a positional parameter

So, when $VISUAL was set, the editor was opened on a file named select, which may create the file, depending on the editor.

Checklist

~[ ] I've added this contribution to the changelog.md.~ (no need, internal-facing)
[x] I've added my name to the AUTHORS file (or it's already there).