search

dbcli / mycli

A Terminal Client for MySQL with AutoCompletion and Syntax Highlighting.
http://mycli.net
Other
11.42k stars 661 forks source link

WIP Default to standards-compliant utf8mb4 character set #935

Open rolandwalker opened 3 years ago

rolandwalker commented 3 years ago

Description

xref #915

The utf8 character set in current MySQL versions is not actually standards-compliant. The standards-compliant UTF-8 character set is spelled utf8mb4, and that should be mycli's default.

~WIP because this should be researched/tested for MariaDB and Percona.~ Edit: tested on MariaDB. Researched for Percona: pages such as https://www.percona.com/blog/2018/04/10/migrating-database-charsets-to-utf8mb4/ have no suggestion of incompatibility.

Checklist

gfrlv commented 3 years ago

I think this default should depend on the server version: mysql < 5.5 cannot handle utf8mb4.

rolandwalker commented 3 years ago

@pasenor excellent point.

rolandwalker commented 3 years ago

Wait, how would that work? We set the charset before we make the connection.

gfrlv commented 3 years ago

Oops, indeed, that's messy. But we should be able call set_charset() on the PyMySQL connection object inside our SQLExecute once know the version

dveeden commented 1 year ago

Note that utf8 is considered an alias for utf8mb3 and both MySQL and MariaDB are actively doing work to eventually change the alias to map to utf8mb4.

Important Change: A previous change renamed character sets having deprecated names prefixed with utf8 to use utf8mb3 instead. In this release, we rename the utf8 collations as well, using the utf8mb3 prefix; this is to make the collation names consistent with those of the character sets, not to rely any longer on the deprecated collation names, and to clarify the distinction between utf8mb3 and utf8mb4. The names using the utf8mb3_ prefix are now used exclusively for these collations in the output of SHOW statements such as SHOW CREATE TABLE, as well as in the values displayed in the columns of Information Schema tables including the COLLATIONS and COLUMNS tables. (Bug #33787300)

The utf8mb4 character set was introduced in MySQL 5.5.4, this was not a G.A. release (5.5.8 was the first G.A. release). So utf8mb4 should be used for MySQL 5.5 and newer.

amjith commented 1 year ago

@rolandwalker Is this PR still valid? Should this be merged?

rolandwalker commented 1 year ago

@amjith yes we should do something about it. Will review.