Get server version from pymysql without additional queries

dbcli / mycli

A Terminal Client for MySQL with AutoCompletion and Syntax Highlighting.

http://mycli.net

Other

11.42k stars 661 forks source link

Get server version from pymysql without additional queries #940

Closed gfrlv closed 3 years ago

gfrlv commented 3 years ago

Description

We can get rid of two queries that ask the server about it's version: the pymysql connection object already contains everything we want to know.

Also, added a numerical representation of the server version, for future convenience if we start adding any version-specific functionality (which I think we should do).

Checklist

[x] I've added this contribution to the changelog.md.
[x] I've added my name to the AUTHORS file (or it's already there).

gfrlv commented 3 years ago

After some research it seems that special treatment of Percona DB is not warranted since dialect-wise it should be perfectly compatible with the underlying MySQL version.