dbcli / pgspecial

Python implementation of postgres meta commands (backslash commands)
BSD 3-Clause "New" or "Revised" License
74 stars 54 forks source link

Complete work done on 108 #109

Closed chagui closed 3 years ago

chagui commented 3 years ago

Description

Hey @amjith, thanks for the swift review and merge. I wasn't expecting such a fast merge :sweat_smile: my previous pull-request was missing two things that I fixed here:

Checklist

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f04a54c). Click here to learn what that means. The diff coverage is 65.51%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #109   +/-   ##
=========================================
  Coverage          ?   29.08%           
=========================================
  Files             ?        6           
  Lines             ?     2486           
  Branches          ?        0           
=========================================
  Hits              ?      723           
  Misses            ?     1763           
  Partials          ?        0           
Impacted Files Coverage Δ
pgspecial/help/commands.py 0.20% <ø> (ø)
pgspecial/main.py 38.18% <52.17%> (ø)
pgspecial/iocommands.py 41.86% <65.15%> (ø)
pgspecial/dbcommands.py 33.60% <66.73%> (ø)
pgspecial/namedqueries.py 92.00% <75.00%> (ø)
pgspecial/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f04a54c...890dde8. Read the comment docs.

amjith commented 3 years ago

Thanks for adding the change to Changelog.

We dropped support for Python 3.5, we are not running our tests with Python 3.5 anymore. But there is no harm in having additional compatibility. Cheers!

chagui commented 3 years ago

Good to know, thanks! Is it an idea to update the classifiers?

amjith commented 3 years ago

Is it an idea to update the classifiers?

Good catch we haven't updated that for most of our projects. We really should add 3.8 and 3.9 to the list. If you have time, feel free to send PRs. If not, I'll update them later this week.