Upgrade pytest to latest version

dbcli / pgspecial

Python implementation of postgres meta commands (backslash commands)

BSD 3-Clause "New" or "Revised" License

74 stars 54 forks source link

Upgrade pytest to latest version #111

Closed chagui closed 3 years ago

chagui commented 3 years ago

Description

This pull-request propose to upgrade pytest to latest version (6.2.4) in order to:

Replace the deprecated yield fixture function decorator, which shows as a warning when running tests
Move pytest configuration to pyproject.toml

I know some people are not fan of moving configuration to pyproject.toml and I would perfectly understand if you want to keep as is.

Checklist

[ ] I've added this contribution to the changelog.rst.
[x] I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
[x] Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

j-bennet commented 3 years ago

What is the benefit of moving pytest settings into pyproject.toml?

chagui commented 3 years ago

The benefit would be less configuration files in the project, and one place to lookup different configuration (project one or tools). However the pyproject.toml is young and not adopted by every tool yet, and I know some project like it some other not so I am totally fine removing that part from the PR. It was more a suggestion rather than "we should do it this way"

j-bennet commented 3 years ago

The benefit would be less configuration files in the project, and one place to lookup different configuration (project one or tools). However the pyproject.toml is young and not adopted by every tool yet, and I know some project like it some other not so I am totally fine removing that part from the PR. It was more a suggestion rather than "we should do it this way"

I see. I don't have a strong preference for pytest.ini over pyproject.toml. If this gets us one less configuration file, and does not break anything, sure, why not.

I think if we do this, we should mention in contributor guide where we configure pytest, otherwise people might not see the config and add pytest.ini back.