dbcli / pgspecial

Python implementation of postgres meta commands (backslash commands)

BSD 3-Clause "New" or "Revised" License

74 stars 54 forks source link

Add optional editor argument to open_external_editor #128

Closed bossstein closed 2 years ago

bossstein commented 2 years ago

Description

I want to be able to use a non default editor in pgcli that I use daily. The click library does support an optional editor in it's click.edit function. As such, I have added an optional argument here to allow further changes in the pgcli project.

Python is not my daily language, as far as I'm aware adding this argument here will not break anything for the current consumers of this code but I am open to being corrected.

Max

Checklist

[x] I've added this contribution to the changelog.rst.
[ ] I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
[x] Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

bossstein commented 2 years ago

@j-bennet hello, can you check this pull request when you have an opportunity?

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2362249). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage        ?   19.93%           
=======================================
  Files           ?        6           
  Lines           ?     3747           
  Branches        ?        0           
=======================================
  Hits            ?      747           
  Misses          ?     3000           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2362249...80ef8fb. Read the comment docs.

bossstein commented 2 years ago

@j-bennet Ok I have added an entry. I put it under upcoming as I assume this change will go into a upcoming version update.

j-bennet commented 2 years ago

@bossstein The PR is now merged. I released 2.0.2 to pypi, so you can update pgspecial version in pgcli in your other PR.

bossstein commented 2 years ago

@j-bennet Thank you :slightly_smiling_face: