dbcli / pgspecial

Python implementation of postgres meta commands (backslash commands)
BSD 3-Clause "New" or "Revised" License
74 stars 54 forks source link

Fix test_slash_l* to support non-en_US locales #141

Closed mgorny closed 10 months ago

mgorny commented 1 year ago

Description

Update the tests to expect the current locale rather than en_US. While technically this isn't 100% guaranteed to be the same locale as the database is running on, I think we can reasonably assume that for the purpose of testing they are the same. Non-UTF-8 locales still are not supported but the other tests seem to be unable to handle them well anyway.

Fixes #140

Checklist

mgorny commented 1 year ago

Damn, I knew this is going to happen — the Docker container is actually using a different locale than GHA environment. I'm going to try if I can set them to match.

j-bennet commented 10 months ago

Thank you @mgorny.

mgorny commented 10 months ago

Thanks!