search

dbcodeio / public

The Power of Databases, The Convenience of VS Code: All in One Place
10 stars 0 forks source link

Feedback on Pre-Release Update: MySQL/MariaDB Create/Edit Table Feature #48

Open devpkr1 opened 23 hours ago

devpkr1 commented 23 hours ago

Hi Mike,

I’ve reviewed the pre-release update for the Create/Edit Table feature for MySQL/MariaDB, and I’ve noticed a few issues:

The Save button is not functioning as expected. The Table Name field is missing. When creating a table, there should be an option to assign a name, and when editing, the table name should be available for renaming. I understand that you’ve already mentioned that the Primary Key and Indexes tabs are coming soon. I would also suggest adding a Triggers tab, allowing users to create/edit triggers directly from there.

For your reference, I’m attaching a screenshot. Screenshot 2024-10-10 103526

Best regards, Pradeep Kumar

mikeburgh commented 19 hours ago

Thanks, yes it's not functional yet in terms of saving.. needs to get a lot of tests written for all the various combos of changes that are possible.

I was going to prompt for the name when saving if it's a new table, and otherwise just display it when editing.. I don't think any SQL servers let you change the name along with altering columns.. so I was going to keep rename as it's own action (it's there now by right clicking on a table).

Triggers is a good idea, but I think I will keep them like store procs, and open them in their own tab.. that way you get the full editor.. anything in these "windows" where you have custom UI, you cannot also get the full editor and hence you loose all the other benifits.. I could show the triggers maybe and clicking on them just opens a new tab.

devpkr1 commented 19 hours ago

Yeah, that's a good idea.

On Thu, 10 Oct 2024, 9:33 pm mikeburgh, @.***> wrote:

Thanks, yes it's not functional yet in terms of saving.. needs to get a lot of tests written for all the various combos of changes that are possible.

I was going to prompt for the name when saving if it's a new table, and otherwise just display it when editing.. I don't think any SQL servers let you change the name along with altering columns.. so I was going to keep rename as it's own action (it's there now by right clicking on a table).

Triggers is a good idea, but I think I will keep them like store procs, and open them in their own tab.. that way you get the full editor.. anything in these "windows" where you have custom UI, you cannot also get the full editor and hence you loose all the other benifits.. I could show the triggers maybe and clicking on them just opens a new tab.

— Reply to this email directly, view it on GitHub https://github.com/dbcodeio/public/issues/48#issuecomment-2405512403, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHX3Z5PILLAPJ3M4ZH6S563Z22QL7AVCNFSM6AAAAABPWTEVYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVGUYTENBQGM . You are receiving this because you authored the thread.Message ID: @.***>