dbcodeio / public

The Power of Databases, The Convenience of VS Code: All in One Place
28 stars 1 forks source link

mariadb introspection error #71

Closed pmsorensen closed 3 weeks ago

pmsorensen commented 1 month ago

Error: FUNCTION ****.JSON_ARRAYAGG does not exist


VSCode Version: 1.94.2 Extension Version: 1.3.7 OS: linux Arch: x64 Database Version: Debian 10 - 10.3.18-MariaDB-0 deb10u1-log

mikeburgh commented 1 month ago

Thanks, it appears that version 10.5 contains the JSON_ARRAYAGG and JSON_OBJECTAGG functions that I use in introspection.

I will look at making a version without those, but it will involve some re working to get it to support it, so not going to be a quick enhancement

For now I have added a check on the version if it's less than 10.5

mikeburgh commented 1 month ago

Fixed in 1.3.11, give it a try and let me know if you have any issues.

pmsorensen commented 1 month ago

Hi, I now get this error:

Error: Invalid use of group function


VSCode Version: 1.94.2 Extension Version: 1.3.12 OS: linux Arch: x64 Database Version: Debian 10 - 10.3.18-MariaDB-0 deb10u1-log

Should I raise an issue?

best, Peter

On Tue, 22 Oct 2024 at 19:30, mikeburgh @.***> wrote:

Fixed in 1.3.11, give it a try and let me know if you have any issues.

— Reply to this email directly, view it on GitHub https://github.com/dbcodeio/public/issues/71#issuecomment-2429970350, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARZESVHHANBNH4M4ET6GYBTZ42KTXAVCNFSM6AAAAABQJZB4S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZHE3TAMZVGA . You are receiving this because you authored the thread.Message ID: @.***>

mikeburgh commented 1 month ago

We can just use this issue, will look into it

mikeburgh commented 4 weeks ago

I have tracked it down to a bug in the group_concat function.

It was fixed in either version 10.3.33 or 10.3.34. I suspect it was fixed in .33 as .34 was a release to fix a problem in .33

The introspection runs in version 10.3.34 without issue, but throws this error in 10.3.32 and below (10.3.33 is no longer available due to what I assume was the reason for .34 release).

Nothing is jumping out at me on this list https://mariadb.com/kb/en/mariadb-10333-changelog/ so not sure how to work around it at this stage.

pmsorensen commented 4 weeks ago

Thanks a lot for looking into this. When we get around to upgrade our servers I'll surely give it another try and let you know.

Cheers, Peter

On Fri, Oct 25, 2024, 00:54 mikeburgh @.***> wrote:

I have tracked it down to a bug in the group_concat function.

It was fixed in either version 10.3.33 or 10.3.34. I suspect it was fixed in .33 as .34 was a release to fix a problem in .33

The introspection runs in version 10.3.34 without issue, but throws this error in 10.3.32 and below (10.3.33 is no longer available due to what I assume was the reason for .34 release).

Nothing is jumping out at me on this list https://mariadb.com/kb/en/mariadb-10333-changelog/ so not sure how to work around it at this stage.

— Reply to this email directly, view it on GitHub https://github.com/dbcodeio/public/issues/71#issuecomment-2436533895, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARZESVHUIC64XJZY66NNB3TZ5GCC3AVCNFSM6AAAAABQJZB4S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZWGUZTGOBZGU . You are receiving this because you authored the thread.Message ID: @.***>

mikeburgh commented 3 weeks ago

Ahh, sorry I should have been clearer, was still going to attack it, just didn't have much of an idea what was causing it. I tracked it down to something to do with nested GROUP_CONTACT calls inside CTE's but couldn't seem to work around it so moved some of the logic out of SQL.

Give it a try now and let me know how it goes, I tested it on a 10.3.10 version without issues.

mikeburgh commented 3 weeks ago

Found a small bug with foreign keys, 1.3.15 fixes it, I will close this, re open it if you are still having issues.