dbcodeio / public

The Power of Databases, The Convenience of VS Code: All in One Place
29 stars 1 forks source link

Enhancement Proposal for Connection Color Settings #72

Open devpkr1 opened 1 month ago

devpkr1 commented 1 month ago

Hi Mike,

I hope this message finds you well.

I have come up with an enhancement idea for the color settings related to connections. The proposal is to allow users to select a specific color for each connection. Once a color is chosen, it will be displayed in the Connection pane for that particular connection, as well as in the connected DBCode notebook.

I have attached some screenshots for your reference.

Image Image

Looking forward to your thoughts on this enhancement.

Best regards, Pradeep Kumar

mikeburgh commented 1 month ago

Not sure if I can set background in the DB Explorer, will have to look and see if that's been exposed.

Where are you thinking for the color in the notebook ?

devpkr1 commented 1 month ago

Its about color of the notebook header , i have used Navicat Premium where i have noted that when we set color to any connection then that color appears on that connection in the connection pane as well as in Header of the opened SQL query tab connected to that database connection.

You have already done this for notebook header but color is not displayed in the connections pane to the particular connection as i have sent you the screenshot.

mikeburgh commented 1 month ago

Confirmed, I can set the text color of the items in the tree, but not the background colors.. so cannot get that effect.

I can change the icon color, which you can see below (Maria and one of the Mongo's have been colored)… It works okay with Maria, might not look good with some of the others, and kinda loose some of that visual clue to which database type it is we get from the colors.

Screenshot 2024-10-24 at 7.38.53 PM.png

I think this one might need to be closed and re opened if VSCode ever open up the ability to change the background for individual items in the tree

devpkr1 commented 3 weeks ago

Hi Mike,

I've noticed that after setting the connection color, it's not working as expected. There’s no visible change in the Active Tab borders or the DB Explorer connection icons. While I understand that changing icon colors might not be ideal, if we’re setting a color for a connection, it should at least be reflected somewhere to help identify the active tab associated with that connection. This would make it easier to see which connection each tab is using, especially when working with multiple DBCode notebooks. A color link between the connection and the Active Tab would streamline identifying connections at a glance.

I've attached a few screenshots for reference

Image Image Image

mikeburgh commented 3 weeks ago

For the editor tabs.. Did the color sow correctly if you closed and re started VSCode.. ?

At the moment the color is only applied in the DB Explorer for the PK highlight.. What be default is purple, but if you set a color it will be that color instead.

I did not like changing the primary connection icons, as it went against brand guidlines for the logos, and there is no other option at the moment to color the explorer

devpkr1 commented 2 weeks ago

Hi Mike,

Yes, the display is correct in the Table Editor tab and for the Primary Key, but it’s not showing up in the Notebook tab. I've attached a screenshot for reference.

Image

Regards, Pradeep