Closed dbeatty10 closed 2 years ago
related to #105 and #109
Consolidated test files across adapters.
The main difference in implementation here is separate pytest folders for each adapter or a single pytest folder for all adapters.
@pytest.mark.skip(reason="Ephemeral materializations not supported for MySQL 5.7")
Both single folder and separate folders can accommodate the following:
tests/conftest.py
test_*.py
This decision could easily go either way.
Ultimately deciding to use a single folder with shared tests across all three adapters because:
CHANGELOG.md
related to #105 and #109
Description
Consolidated test files across adapters.
Trade-offs
The main difference in implementation here is separate pytest folders for each adapter or a single pytest folder for all adapters.
Single folder pros
Single folder cons
Separate folders pros
@pytest.mark.skip(reason="Ephemeral materializations not supported for MySQL 5.7")
Separate folders cons
Neither here nor there
Both single folder and separate folders can accommodate the following:
tests/conftest.py
and then re-used in eachtest_*.py
moduleDecision
This decision could easily go either way.
Ultimately deciding to use a single folder with shared tests across all three adapters because:
Checklist
CHANGELOG.md
with information about my change