Upgraded to dbt-core 1.4.

dbeatty10 / dbt-mysql

dbt-mysql contains all of the code enabling dbt to work with MySQL and MariaDB

Apache License 2.0

75 stars 53 forks source link

Upgraded to dbt-core 1.4. #146

Closed lpezet closed 1 year ago

lpezet commented 1 year ago

resolves #122

Description

Upgrading to dbt-core 1.4:

now using field() from dataclasses package for policy fields definition. Consequently updated code to then use get_default_include_policy() to access class field
using DbtRuntimeError instead of RuntimeException
using FailedToConnectError instead of FailedToConnectException
using dbt.exceptions.DbtDatabaseError instead of dbt.exceptions.DatabaseException
updated requirements-dev.txt to use dbt-core 1.4.latest
using dbt.exceptions.CompilationError instead of deprecated dbt.exceptions.raise_compiler_error

Checklist

[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have updated the CHANGELOG.md with information about my change

lpezet commented 1 year ago

@dbeatty10 Not sure whether this project is still (even if sporadically) maintained but I'm in need to using dbt-mysql with dbt-core 1.4. ~~I'm having issues getting the docker-compose up and running (it starts but then each db says something is already running on their 3306 port) and I haven't figured out how to fix that yet.~~ All good now. Having sait that, the following tests pass:

Unit tests
Functional tests for mysql, mysql5, and mariadb using docker-compose.

dbeatty10 commented 1 year ago

🚀 Thank you for your work here @lpezet !

I won't be able to spend time this week on reviewing this, but can give it a review next week.

lpezet commented 1 year ago

@moszutij Thanks. I just made those changes. Weird my VSCode didn't catch those... @dbeatty10 Awesome! Thx!

BamboOSZ commented 1 year ago

👀

wesen commented 1 year ago

I was just trying this one out @lpezet , and I think dbt.exceptions.DatabaseException needs to be updated to dbt.exceptions.DbtDatabaseError. I haven't done a deeper dive, just running my setup through it.

lpezet commented 1 year ago

@wesen Thanks. I'll fix those. My VSCode somehow is not showing those. If you have any good setup to share (linter, etc.) that would be great.

wesen commented 1 year ago

@lpezet I use intellij idea/pycharm, but in this case just saw it by... writing bad SQL :)

uraurora commented 1 year ago

Why this pr not being merged? Any progress now?

lucasfcnunes commented 1 year ago

I can't find the 1.4 release

outinim commented 10 months ago

Why is the 1.4 version is not linked to the main branch ? cc @dbeatty10 🙏🏼 What do you need to update the release ?