dbeatty10 / dbt-mysql

dbt-mysql contains all of the code enabling dbt to work with MySQL and MariaDB
Apache License 2.0
75 stars 53 forks source link

Show how to close multiple issues in the pull request template #153

Open dbeatty10 opened 1 year ago

dbeatty10 commented 1 year ago

❌ Easy mistake

GitHub has a nice feature:

When you merge a linked pull request into the default branch of a repository, its linked issue is automatically closed. For more information about the default branch, see "Changing the default branch."

But the syntax I've most often seen people try to use is like:

Resolves #10 #123 octo-org/octo-repo#100

In that case, only the 1st issue is linked and automatically closed; the other two will not be linked and will not be closed.

✅ Solution

Many contributors don't realize the syntax required by GitHub to close multiple requests at the same time:

Resolves #10, resolves #123, resolves octo-org/octo-repo#100

This is the way to go!

💡 Proposed feature

If the example in the pull request template shows how to close multiple issues, it increases the chances people will see it and use it.