search

dbeatty10 / dbt-mysql

dbt-mysql contains all of the code enabling dbt to work with MySQL and MariaDB
Apache License 2.0
75 stars 53 forks source link

Update dbt-core to 1.5.9 and implement support for model contracts #159

Closed mwallace582 closed 9 months ago

mwallace582 commented 11 months ago

resolves #145

Description

I've followed the instructions published for updating to dbt-core 1.5 and implemented support for model contracts. I targeted 1.5.9 given that it was the latest and greatest version of 1.5.

I was able to get all of the new test classes to pass, and model contracts are working as expected for my dbt models.

There's some trickiness with the difference between types that MySQL allows in schemas, and the types that can be passed into calls to CAST(). I've handed some of the obvious cases, but it's possible that there are gaps with more obscure types.

Not all of my changes are strictly necessary (such as the upgrade to mysql-connector-python). I'd be happy to take any and all feedback.

Checklist

cknowles commented 10 months ago

@dbeatty10 is there some way I could help get this PR merged?

mwallace582 commented 9 months ago

I'm closing this MR in favor of #163 which contains the same work.