Closed kzajaczkowski closed 4 months ago
@kzajaczkowski Could you please squash your commits ?
@kzajaczkowski Could you please squash your commits ?
Done, can you please recheck?
Thank you for the pull request! I just have a few small comments, but otherwise looks good. I like the idea of exposing this in the adapters configuration file.
@mwallace582, thank you for your comments! I've accepted one suggestion, commented on the other one, and also pushed support for mariadb and mysql5 which were missing from the initial PR.
Pipelines are failing though. I've tried to recreate it on my local env and they fail for the main branch as well. So far I didn't manage to find the source of the issue. Any recommendations?
Thank you for making the fixes. I'll look into the test failures, at first glance they look unrelated to your changes.
I've fixed tests in #174. Would you mind re-targeting this pull request at 1.7.latest
and merging with that branch? That should fix the tests.
resolves #172
Description
utf8mb4
which wasutf8mb4_general_ci
. The correct default one isutf8mb4_0900_ci_ai
and 8.1 version uses it by default.profiles.yml
which is useful if someone wants to use different charsets and collations by defaultChecklist
CHANGELOG.md
with information about my change