search

dbekaert / RAiDER

Raytracing Atmospheric Delay Estimation for RADAR
Apache License 2.0
70 stars 39 forks source link

[Feature request] HTTP timeout option #666

Open garlic-os opened 2 months ago

garlic-os commented 2 months ago

Context/motivation Certain pieces of crucial funcionality rely on HTTP requests to external APIs. As we who use RAiDER regularly know, sometimes these APIs take a very long time to respond. I think being able to set a maximum amount of time RAiDER waits for an HTTP response could improve user experience and decrease development time.

Feature description I would like to see an option added to RAiDER's YAML format that allows the user to define the amount of time they are willing to wait for a single HTTP request. My idea for a sensible default would be 30 seconds, or maybe 2 minutes (which is about the amount of time RAiDER waits right now). Speaking optimistically, this may only involve passing a timeout argument to the API calls that make HTTP the requests and adding the option to runtime_group.

jlmaurer commented 1 month ago

Adding a note on this that HTTP timeouts are causing CircleCI failures, so adding a timeout parameter to all the unit tests (specifically test_downloadGNSS.py is failing right now due to this issue) would help improve unit test reliability.