search

dbekaert / RAiDER

Raytracing Atmospheric Delay Estimation for RADAR
Apache License 2.0
70 stars 39 forks source link

`_entrypoints.py`, `_scenario_1.py`, and `_scenario_2.py` are unused #680

Open garlic-os opened 1 month ago

garlic-os commented 1 month ago

Describe the bug I cannot find any instance where a file imports from _entrypoints.py, _scenario_1.py, or _scenario_2.py, and pytest does not pick them up.

To Reproduce Steps to reproduce the behavior:

  1. Enumerate pytest tests and observe that the files in question are not present
  2. Use vscode search/grep or similar to check for mentions of the filenames in the project and observe that they are never mentioned

Expected behavior Are these tests intended to be used? If they are but are just out of commission right now perhaps we can add a comment to them to explain their situation for people looking at them.

Desktop (please complete the following information):

jhkennedy commented 1 month ago

@garlic-os I believe the intent with these tests was to temporarily disable them by removing the test prefix from the file name -- e.g., test_entrypoints.py was renamed to _entrypoints.py here: https://github.com/dbekaert/RAiDER/pull/364#issuecomment-1297635852

test_entrypoints.py at least should be re-enabled to test that these CLI entry points all do exist and are installed properly: https://github.com/dbekaert/RAiDER/blob/dev/pyproject.toml#L44-L51

jlmaurer commented 1 month ago

@garlic-os yes that's correct, these tests were temporarily disabled due as these were end-to-end tests that were downloading files at testing time instead of mocking and/or using cached files, with the result that they would hang if for example one of the weather model servers was out of commission. Some of these have been replaced in part by other tests (e.g., test_synthetic) but not fully. Eventually we'll need to re-visit and integrated them with the new tests that have been introduced.