search

dbeley / rymscraper

Python library to extract data from rateyourmusic.com.
MIT License
163 stars 25 forks source link

Hotfixes in getting rym charts #33

Closed Chotom closed 2 years ago

Chotom commented 2 years ago

Great tool, but found some issues while getting some rym charts data. So I decided to fixed them and create pull request.

1. Missing '/' at the end of url address

For rym there is a diffrence between:

The first url (before fix) link to first page instead to second. Added '/' to the end of url fixed the issue.

2. Invalid class name in next page condition in get_chart_infos function

Solution: Updated class name to 'ui_pagination_next' in next page condition in get_chart_infos function (previous class name 'navlinknext' is no longer valid at the rym webpage). Also, in test_chart.py added checking out next page for rym charts.

codecov[bot] commented 2 years ago

Codecov Report

Merging #33 (6760566) into master (1066877) will increase coverage by 1.82%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   44.20%   46.03%   +1.82%     
==========================================
  Files           4        4              
  Lines         328      328              
  Branches       57       57              
==========================================
+ Hits          145      151       +6     
+ Misses        168      162       -6     
  Partials       15       15
Impacted Files Coverage Δ
rymscraper/rymscraper/RymUrl.py 100.00% <0.00%> (ø)
rymscraper/rymscraper/__init__.py 43.96% <0.00%> (+5.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1066877...6760566. Read the comment docs.

dbeley commented 2 years ago

Thanks a lot for the fix, it's now merged!