search

dbeurle / neon

A finite element code
Other
12 stars 8 forks source link

Generate time functionality #140

Closed dbeurle closed 5 years ago

dbeurle commented 5 years ago

What's the purpose of simulation["time"]["increments"]["initial"]? I'm refactoring the integration stuff and I'm confused at the role that this plays. It seems to be stored inside the meshes and is only used for constructing boundary conditions. Do you have any insight into this issue?

shadisharba commented 5 years ago

This is related to #114 and cyclic loading. Only simulation["meshes"] is passed to the mesh class. However, the generation of a cyclic loading requires early access to simulation["time"] to construct the whole load history. This can change depending on #114.

dbeurle commented 5 years ago

Okay - but it shouldn't need to be stored inside the class? It could be passed as an argument until the timer view is implemented, or?

shadisharba commented 5 years ago

True, it's needed only in allocate_boundary_conditions and allocate_displacement_boundary.

dbeurle commented 5 years ago

Okay cool, then I'll change it for now until we have a better idea about #114. Thanks :-)