search

dbiir / UER-py

Open Source Pre-training Model Framework in PyTorch & Pre-trained Model Zoo
https://github.com/dbiir/UER-py/wiki
Apache License 2.0
3.01k stars 525 forks source link

Possible typo. models/gpt2/config.json #307

Closed Creative-Ataraxia closed 2 years ago

Creative-Ataraxia commented 2 years ago

cause: "target": ["lm"], will cause hashing error when executing scripts/generate_lm.py line 29 correction: removed [] -> "target": "lm",

Eric8932 commented 2 years ago

All targets of this project must be in the form of a list and the target of generate_lm.py could only be LmTarget. So maybe you could specify the target in generate_lm.py as LmTarget, as in scripts/generate_seq2seq.py, and pull another request. Thanks a lot!

Embedding commented 2 years ago

cause: "target": ["lm"], will cause hashing error when executing scripts/generate_lm.py line 29 correction: removed [] -> "target": "lm",

Probably it is a better choice to modify the scripts/generate_lm.py since the project uses the list to store targets by default.

Creative-Ataraxia commented 2 years ago

will look at changes directly on generate_lm.py when I'm able