search

dbikard / genomenotebook

A genome browser in your Jupyter notebook
Apache License 2.0
26 stars 1 forks source link

Genbank #5

Open dbikard opened 1 year ago

dbikard commented 1 year ago

CI seems to fail because of " Detected unstripped out notebooks\n!!!Remember to run nbdev_install_hooks' Could you maybe run nbdev_clean or nbdev_prepare and make a new commit? I also saw the change you made for Python 3.11, but it's unclear to me whether this will break compatibility with previous Python versions? It would be good to make sure the package also work for people using older versions.

seanrjohnson commented 1 year ago

I'm pretty confident that the 3.11 change I made with Mapping won't affect compatibility with any version above at least 3.5, I think probably back to 3.3.

I'll look at the CI issue.

dbikard commented 1 year ago

I made substantial changes to enable genbank as input as well as z stacking. @seanrjohnson Can you have a look and see if anything I changed in your code needs to be fixed?

We also still need to improve the docs to highlight the new features as well as test everything thoroughly before we can merge,

dbikard commented 1 year ago

I now see that the way you changed how attributes are kept in the patches DataFrame and added to the hover tool mean that it is no longer feasible for the user to easily add data to be displayed when hovering as was shown in the Options notebook "Adding information to be displayed when hovering". The user would now have to modify the GFF file which is not very convenient. I'll try to think about a possible fix.

dbikard commented 1 year ago

I now see that the way you changed how attributes are kept in the patches DataFrame and added to the hover tool mean that it is no longer feasible for the user to easily add data to be displayed when hovering as was shown in the Options notebook "Adding information to be displayed when hovering". The user would now have to modify the GFF file which is not very convenient. I'll try to think about a possible fix.

This is now fixed with a custom function to add data to the tooltip.