search

dbinfrago / libpax

Apache License 2.0
21 stars 13 forks source link

v1.1.0 #20

Closed cyberman54 closed 1 year ago

cyberman54 commented 2 years ago

fix issue #19

cyberman54 commented 1 year ago

@oliverbrandmueller ping

cyberman54 commented 1 year ago

Added a fix to solve issue #21

lifezoned4 commented 1 year ago

the code LGTM but one of the unit test fails because the counting of the report intervals is not summing up to 6 in 6 sec (1 sec per report) for espidf env. I think this has to do with the espressif32@5.2.0 version bump. For now I would say we give the delay 10ms more in test/libpax_test_cases.cpp:125. I don't see any problem in the actually timing when looking at esp_timer_get_time values in between the reports. So I assume it is a problem with vTaskDelayUntil?

The arduino env works fine without any unit test change.

Perhaps Also bump the version in library.json to 1.1.0 so we can go for a release?

cyberman54 commented 1 year ago

@lifezoned4 fixed it, thanks for pointing to the Vtaskdelay timer. I set it to 6010 now. Will try to find out what's the root cause here.

cyberman54 commented 1 year ago

This PR should now be ready to merge. /cc @lifezoned4

cyberman54 commented 1 year ago

@oliverbrandmueller for this PR we need the Release 1.1.0, too.

cyberman54 commented 1 year ago

@oliverbrandmueller Platformio library manager does not find v1.1.0, does it need a kick?

image

cyberman54 commented 1 year ago

@FlorianLudwig @oliverbrandmueller We need a pio pkg publish for v1.1.0 of this lib by owner greyrook!

image

lifezoned4 commented 1 year ago

Did a publish bump and it should be available now. @cyberman54

cyberman54 commented 1 year ago

@lifezoned4 now it works in platformio, thanks.