dbinfrago / libpax

Apache License 2.0
21 stars 13 forks source link

Major bug in mac_add() limiting processing to 256 MACs #7

Closed cyberman54 closed 3 years ago

cyberman54 commented 3 years ago

I spotted a major bug in _macadd(), which causes this library to process only 1 byte (instead of 2) of universal MACs. Thus, a maximum of 256 different MACs, instead of 65536, can be evaluated. This is pushing counts down to a maximum of 256 unique MACs.

Solved by PR #6.

PS: If any benchmarks were carried out with this version, they should be re-run with the patch.

/cc @spmrider @FlorianLudwig