dbjorkholm / FORGOTTENSERVER-ORTS

Try to make the perfect open real tibia server!
60 stars 76 forks source link

Crash agan I think is notrash.lua again core log debug #557

Closed felipetmartini closed 10 years ago

felipetmartini commented 10 years ago
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff5936700 (LWP 2383)]
0x000000000088b322 in Item::getTile() const ()
(gdb) bt
#0  0x000000000088b322 in Item::getTile() const ()
#1  0x00000000009f8b95 in Thing::getPosition() const ()
#2  0x00000000009f874f in Teleport::__addThing(int, Thing*) ()
#3  0x00000000009f853e in Teleport::__addThing(Thing*) ()
#4  0x00000000009ff253 in Tile::postAddNotification(Thing*, Cylinder const*, int, cylinderlink_t) ()
#5  0x0000000000812320 in Game::internalMoveItem(Cylinder*, Cylinder*, int, Item*, unsigned int, Item**, ---Type <return> to continue, or q <return> to quit---
unsigned int, Creature*, Item*) ()
#6  0x00000000008113de in Game::playerMoveItem(unsigned int, Position const&, unsigned short, unsigned char, Position const&, unsigned char) ()
#7  0x000000000080f73d in Game::playerMoveThing(unsigned int, Position const&, unsigned short, unsigned char, Position const&, unsigned char) ()
#8  0x000000000084a9ad in std::_Mem_fn<void (Game::*)(unsigned int, Position const&, unsigned short, unsi---Type <return> to continue, or q <return> to quit---
gned char, Position const&, unsigned char)>::operator()(Game*, unsigned int, Position const&, unsigned short, unsigned char, Position const&, unsigned char) const ()
#9  0x0000000000845cc0 in _ZNSt5_BindIFSt7_Mem_fnIM4GameFvjRK8PositionthS4_hEEPS1_jS2_thS2_hEE6__callIvJEJLm0ELm1ELm2ELm3ELm4ELm5ELm6EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE ()
---Type <return> to continue, or q <return> to quit---
DpOT_ ()
#11 0x000000000083730d in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (Game::*)(unsigned int, Position const&, unsigned short, unsigned char, Position const&, unsigned char)> (Game*, unsigned int, Position, unsigned short, unsigned char, Position, unsigned char)> >::_M_invoke(std::_Any_data const&) ()
#12 0x00000000009f693c in std::function<void ()>::operator()() const
    ()
---Type <return> to continue, or q <return> to quit---
#13 0x00000000009f6810 in Task::operator()() ()
#14 0x00000000009f63a0 in Dispatcher::dispatcherThread() ()
#15 0x00000000009f7fb3 in std::_Mem_fn<void (Dispatcher::*)()>::operator()(Dispatcher*) const ()
#16 0x00000000009f7f03 in _ZNSt12_Bind_simpleIFSt7_Mem_fnIM10DispatcherFvvEEPS1_EE9_M_invokeIJLm0EEEEvSt12_Index_tupleIJXspT_EEE ()
#17 0x00000000009f7e01 in std::_Bind_simple<std::_Mem_fn<void (Dispatcher::*)()> (Dispatcher*)>::operator---Type <return> to continue, or q <return> to quit---
()() ()
#18 0x00000000009f7d9a in std::thread::_Impl<std::_Bind_simple<std::_Mem_fn<void (Dispatcher::*)()> (Dispatcher*)> >::_M_run() ()
#19 0x00007ffff71a3400 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#20 0x00007ffff66b4b50 in start_thread ()
   from /lib/x86_64-linux-gnu/libpthread.so.0
#21 0x00007ffff69a60ed in clone ()
   from /lib/x86_64-linux-gnu/libc.---Type <return> to continue, or q <return> to quit---
so.6
#22 0x0000000000000000 in ?? ()
felipetmartini commented 10 years ago

for what is used notrash i realy dont understand this, can someone with for info help here??? But sure this is a datapack crash many players here are reporting this issue Also iam using last notrash from github

EPuncker commented 10 years ago

https://github.com/otland/forgottenserver/issues/822#issuecomment-43661100

felipetmartini commented 10 years ago

@EPuncker @marksamman already sayd this is a datapack issue so no need to link here we need to try fix this, maybe @PrinterLUA can help

dbjorkholm commented 10 years ago

Wouldn't it be wiser to use Player:onMoveItem instead? :p

e.g

function Player:onMoveItem(item, count, fromPosition, toPosition)
    local tile = toPosition:getTile()
    if tile then
        local thing = tile:getItemByType(ITEM_TYPE_TELEPORT)
        if thing ~= nil then
            self:sendCancelMessage("Sorry, not possible.")
            self:getPosition():sendMagicEffect(CONST_ME_POFF)
            return false
        end
    end
    return true
end
felipetmartini commented 10 years ago

Maybe you are correct, will see if more people think this too

felipetmartini commented 10 years ago

Also i dont understand notrash for what have this?why tfs dont use this?

EPuncker commented 10 years ago

because it is a custom is script that printer made for this datapack lol, read that simple code and you will understand what it do, you can remove it from you server if you want to

felipetmartini commented 10 years ago

If this is so simple why none can fix that crash, many people are reproducing that, i think this a priority inssue many crash by day Fron this

Enviado via iPhone

Em 24/05/2014, às 00:06, Evil Puncker notifications@github.com escreveu:

because it is a custom is script that printer made for this datapack lol, read that simple code and you will understand what it do, you can remove it from you server if you want to

— Reply to this email directly or view it on GitHub.

EPuncker commented 10 years ago

if you take a look at the link that I've sent you will see that there is nothing that can be done and this is still an open issue at tfs: https://github.com/otland/forgottenserver/issues/21

felipetmartini commented 10 years ago

sure but mark say its not a tfs issue he say is a printer datapack ,or i understand wrong? i think mark not will fix that

EPuncker commented 10 years ago

mark will fix issue #21 someday, then printer script will work, I can't explain xd

dbjorkholm commented 10 years ago

I'll remove notrash.lua from the repository and add what I posted above (doesn't crash the server at least). x)

felipetmartini commented 10 years ago

nice @ninjalulz

EPuncker commented 10 years ago

https://github.com/PrinterLUA/FORGOTTENSERVER-ORTS/commit/0d159069e39532598626c28db36bebf6dd281e4c

now lets see if your crash continues or we can close this issue =d

felipetmartini commented 10 years ago

nice