search

dblanque / opnsense-zabbix

Zabbix Template for OPNSense
14 stars 0 forks source link

Breaking changes in 24.1 #1

Closed th3voic3 closed 7 months ago

th3voic3 commented 7 months ago

Hi,

I really like this template first of all. In 24.1 the function get_interfaces_info was removed breaking the opnsense_zbx.php script.

dblanque commented 7 months ago

Oof, that's a bummer...

I haven't implemented version 24.1 in any environment yet, any idea if this function was only re-named/re-implemented or was it fully deleted from OPNSense?

Thanks, Dylan

th3voic3 commented 7 months ago

I'm not really sure yet if there is an adequate replacement.

The function was removed in this commit: https://github.com/opnsense/core/commit/4d495ea6cc3d3c993662867bf3b3a072069e1fc8

dblanque commented 7 months ago

Thank you so much for finding that, I appreciate it. From what I could check get_interface_list and get_interfaces_info might be related but I'm not entirely sure they give the required/same info. I'll check it out as soon as I have that version available on a host.

dblanque commented 7 months ago

@th3voic3 Please let me know if it's working for you now! I also went ahead and added a small fix in the Network Discovery function to check for strlen (Empty interface name detected bug).

th3voic3 commented 7 months ago

@dblanque looking good. Thanks for the quick fix and I'm honored for being mentioned in the code :)

dblanque commented 7 months ago

No problem! Lemme know if you find any more issues. I updated the YAML Templates by the way with some more statistic goodies for the auto-discoverable interfaces. Cheers!