search

dblock / iex-ruby-client

IEX Finance API Ruby Client
MIT License
118 stars 60 forks source link

Money library change #110

Closed agrberg closed 2 years ago

agrberg commented 2 years ago

While working with the money_helper library to enable the upgrade in https://github.com/dblock/iex-ruby-client/pull/109 I realized my non-breaking change in https://github.com/artsy/money_helper/pull/27 would eventually need to be a breaking change to improve the API. with_symbol is just a pass through to symbol for the Money#format options and that PR enables those to be passed through directly.

When I looked at the money library itself, I determined Resource.to_dollar could instead depend on an even smaller interface as the defaults make sense for the purposes of a US market API.

A minor drawback/benefit is that this effectively drops the hidden dependency on activesupport (for built gems, it is still needed in test for danger-toc).

Feedback very welcome 🙏

dblock commented 2 years ago

Merged. Maybe we should release as 1.6, feels too major for a patch version bump.