search

dblock / iex-ruby-client

IEX Finance API Ruby Client
MIT License
118 stars 60 forks source link

Move CI to GHA #117

Closed agrberg closed 2 years ago

agrberg commented 2 years ago

resolves #116

agrberg commented 2 years ago

The error on Ruby 3.0 and 3.1 is because Rubocop changed how it works under the hood. I'm installing Ruby 3.0 now to see what's the minimum version of Rubocop needed to get the Ruby min 2.4 working on 3.0 before addressing the 2.7 update.

agrberg commented 2 years ago

Alright! Looks like it's passing on Rubies 2.7, 3.0, and 3.1 now and can be reviewed 😌

dblock commented 2 years ago

The error on Ruby 3.0 and 3.1 is because Rubocop changed how it works under the hood. I'm installing Ruby 3.0 now to see what's the minimum version of Rubocop needed to get the Ruby min 2.4 working on 3.0 before addressing the 2.7 update.

Adding Ruby 3.0 support can be done later, separately. Get a minimum amount of GHA to pass.

agrberg commented 2 years ago

GitHub's CI is still a little new to me but if I'm reading the workflows correctly it looks like the last push to this branch yesterday passed as did the update this morning to remove the concurrency from test.yml

I can move the two commits related to Ruby 3.0 and 3.1 to another PR if you feel strongly. I wanted to point out that they're essentially behind-the-scenes trivial changes though:

Please let me know if I'm missing something obvious 😅

agrberg commented 2 years ago

Thanks for the patience and tips. I believe the Danger workflow isn't kicking off because it is only done when making a PR as opposed to updating a PR. GHA's UI isn't letting me run in manually either. My assumption there is because it's new and hasn't ever been run. Kind of a catch-22 🥲

dblock commented 2 years ago

Merged! Let's see those other PRs.