Double check "largest-trades" behavior when multiple trades are returned

rodolfobandeira commented 5 years ago

For next week, while trading hours is running (~9:45am - 4:00pm), confirm how the largest-trades endpoint behaves on the following:

How it orders the list? From largest trades to lower?
How many elements are displayed on this list?
Is it indeed a list or just shows the largest trade for that day? (If that is just one, the IEX documentation is wrong since it shows an array list)
If it returns a list of elements indeed, fix tests and review our code to make sure it handles multiple trades;

cc: @dblock @gil27

gil27 commented 5 years ago

Hey @rodolfobandeira, it is a list. I don't remember how it orders it but it is a list. On tests I've use trades.first to check values and also have a test to check the quantity of results.

I think my mistake was in README.md where I didn't make it clear that it was a list.

rodolfobandeira commented 5 years ago

@gil27 Yeah, it is a bit confusing since there are Sectors calls on your LargestTrades rspec.

But don't worry, lets take a look this next week. Cheers!

rodolfobandeira commented 5 years ago

Hey guys! Got some information today:

The returned list is ordered by number of shares negotiated ordered by desc;
The generated list is based on daily data, so after the daily trading ends, the returned list is empty;

[
  {
    "price": 217.76,
    "size": 9000,
    "time": 1539699300665,
    "timeLabel": "10:15:00",
    "venue": "None",
    "venueName": "Off Exchange"
  },
  {
    "price": 217.36,
    "size": 8171,
    "time": 1539699439595,
    "timeLabel": "10:17:19",
    "venue": "XNGS",
    "venueName": "Nasdaq"
  },
  {
    "price": 218.671,
    "size": 7444,
    "time": 1539697175918,
    "timeLabel": "09:39:35",
    "venue": "None",
    "venueName": "Off Exchange"
  },
  {
    "price": 218.09,
    "size": 7220,
    "time": 1539698909729,
    "timeLabel": "10:08:29",
    "venue": "None",
    "venueName": "Off Exchange"
  },
  {
    "price": 217.81,
    "size": 6300,
    "time": 1539699334482,
    "timeLabel": "10:15:34",
    "venue": "None",
    "venueName": "Off Exchange"
  },
  {
    "price": 218.7,
    "size": 6000,
    "time": 1539696843070,
    "timeLabel": "09:34:03",
    "venue": "None",
    "venueName": "Off Exchange"
  },
  {
    "price": 218.258,
    "size": 6000,
    "time": 1539696980111,
    "timeLabel": "09:36:20",
    "venue": "None",
    "venueName": "Off Exchange"
  },
  {
    "price": 218.62,
    "size": 6000,
    "time": 1539697154187,
    "timeLabel": "09:39:14",
    "venue": "None",
    "venueName": "Off Exchange"
  },
  {
    "price": 216.963,
    "size": 6000,
    "time": 1539700749730,
    "timeLabel": "10:39:09",
    "venue": "None",
    "venueName": "Off Exchange"
  },
  {
    "price": 216.87,
    "size": 5986,
    "time": 1539700719236,
    "timeLabel": "10:38:39",
    "venue": "None",
    "venueName": "Off Exchange"
  }
]

gil27 commented 5 years ago

Nice @rodolfobandeira, if there is no problem I will fix the README.md ok?

rodolfobandeira commented 5 years ago

@gil27 Sorry, just saw your msg now. Please check #36

gil27 commented 5 years ago

Haha, it's ok👍 I've post it a few minutes ago. =)

dblock / iex-ruby-client

Double check "largest-trades" behavior when multiple trades are returned #35