search

dblock / iex-ruby-client

IEX Finance API Ruby Client
MIT License
119 stars 60 forks source link

Added IEX::Resources::OHLC#get and IEX::Resources::OHLC#market #5

Closed jromanovs closed 6 years ago

jromanovs commented 6 years ago

Add ability to gather stock OHLC prices as well for all market. Hope you will find those changes helpful.

jromanovs commented 6 years ago

Sorry, if it is a newbie questions. I was commit all requested changes. Does it required any more actions from my side? Or just wait when you have a chance to apply changes? Does it need to invest from myself some more time to extend functionality? I am curious, because found that market prices provided by IEX Group API is far from best or may be I miss something. Have a good day :)

dblock commented 6 years ago

Sorry just seeing this, github doesn't notify on updates. Changes merged.

dblock commented 6 years ago

@jromanovs Interested in helping out with this library? Maybe make the next release? If yes sign up on rubygems.org and lmk which email address you used.

dblock commented 6 years ago

@jromanovs see question above on helping with releases? ^

jromanovs commented 6 years ago

Sorry, was busy with other projects. I was registered @ ruby gems.org as with email jromanovs@gmail.com. Hope that can be helpful on next week. I was already started another feature for bulk requests. I have a plans to make some commits on next week and then be happy to help with next release. How about such plan?

dblock commented 6 years ago

Sounds great! Thanks. Added you to Rubygems and invited you to the project, https://github.com/dblock/iex-ruby-client/invitations