search

dblock / iex-ruby-client

IEX Finance API Ruby Client
MIT License
118 stars 60 forks source link

Faraday::Error::ResourceNotFound Did you mean? Faraday::ResourceNotFound #79

Closed Souravgoswami closed 3 years ago

Souravgoswami commented 3 years ago

Hi, if I search for some term that doesn't exist, I get:

Faraday::Error::ResourceNotFound Did you mean? Faraday::ResourceNotFound

So Instead of rescuing Faraday::ResourceNotFound, I have to rescue NameError now.

dblock commented 3 years ago

This is a Faraday versioning problem, either lock Faraday < 1, or upgrade the client to Faraday 1.0 similarly to https://github.com/dblock/open-weather-ruby-client/pull/13. Want to give it a shot in a PR?

Souravgoswami commented 3 years ago

I just wanted to send PR, but it's fixed before that... Thanks for the quick action!

dblock commented 3 years ago

It's not fixed AFAIK, we didn't do anything.

dblock commented 3 years ago

Oh I see, it was done part of https://github.com/dblock/iex-ruby-client/pull/71, we just need to do a release.

dblock commented 3 years ago

I released 1.2.0.