search

dblock / iex-ruby-client

IEX Finance API Ruby Client
MIT License
119 stars 60 forks source link

Added Advanced Stats Module #84

Closed FanaHOVA closed 3 years ago

FanaHOVA commented 3 years ago

Taking over orphaned #53.

@dblock I also added dotenv to help with the ENV issue for generating VCRs. I lazily added DeepSource as well to run transformers for me because I forget to locally :)

rodolfobandeira commented 3 years ago

LGTM. I'm not sure about the deepsource and .env but I'll let more people comment on that

dblock commented 3 years ago

LGTM. I'm not sure about the deepsource and .env but I'll let more people comment on that

The .env construct is pretty common, instead of having to rely on export you can have a .env file that does not get checked in (we already include it in .gitignore) and load it via dotenv. That's what I typically do in development and the addition here makes it "just work".

FanaHOVA commented 3 years ago

@dblock Makes sense, just removed the .toml file. Should be good to go.

dblock commented 3 years ago

Merged, thanks.