dblock / iex-ruby-client

IEX Finance API Ruby Client
MIT License
118 stars 60 forks source link

Add logger config module #88

Closed agrberg closed 3 years ago

agrberg commented 3 years ago

That makes sense. I didn't go down a deeper path to get the work done sooner. Would they both get included into Client for something like

IEX::Api::Client.logger do |logger|
  logger.instance = Logger.new(STDOUT)
  logger.options = { bodies: true }
  logger.proc = proc { |logger| logger.filter(/T?[sp]k_\w+/i, '[REMOVED]') }
end
# and for compatibility (needed any longer?)
IEX::Api::Client.logger = Logger.new(STDOUT)
dblock commented 3 years ago

Yes, I think we want all these variations.

dblock commented 3 years ago

👏 @agrberg want to help out with co-maintaining this library? If yes email me your rubygems email to dblock[at]dblock[dot]org and I'll give you r/w permissions. Maybe you can publish the next release?