search

dblock / iex-ruby-client

IEX Finance API Ruby Client
MIT License
119 stars 60 forks source link

Backfill breaking change #89

Closed agrberg closed 3 years ago

agrberg commented 3 years ago

I found a breaking change where we could no longer assign the logger through the config object. The following was broken by #88 

IEX::Api.configure do |config|
  config.logger = logger
end
# and
IEX::Api::Client.new(logger: logger)

I fixed that in this PR as to not release a Gem version w/ a breaking change unless necessary. I also changed how IEX::Api is augmented to provide logger and config. I believe it makes it clearer where the methods come from as well as making those in Logger reusable for Config::Client's extension. Let me know what you think.