dblock / msiext

AppSecInc. Community MSI Extensions
Eclipse Public License 1.0
85 stars 109 forks source link

Wix37 #2

Closed thcristo closed 11 years ago

thcristo commented 11 years ago

Hi,

I don't know if there is any roadmap for this project but I have upgraded to VS2010, Wix3.7 and latest C++ libraries (Boost, cryptlib, cppunit). The build process completes OK, there are several failures when running the unit tests.

dblock commented 11 years ago

Thanks, this gets us closer. What test failures are you getting? Make sure to run tests as Administrator.

thcristo commented 11 years ago

I was getting errors in ActiveDirectoryUnitTests, DataSourceUnitTests, OdbcUnitTests, LsaUnitTests, UserPrivilegesUnitTests but I found out that these errors are unrelated to the migration to wix37/vs2010. The old unit tests (wix35/vs2005) also exhibit the same behavior.

The errors have to do with my specific domain configuration and SQL Server configuration. When I run the unit tests in machines with the expected configuration, no errors occur. So I suppose that the migration has not introduced new errors.

dblock commented 11 years ago

This is great. I got some build failures in the debug build:

"C:\Users\dblock\Source\GitHub\msiext\dblock\msi.proj" (build target) (1) ->
"C:\Users\dblock\Source\GitHub\msiext\dblock\Msi.sln" (Build target) (2) ->
"C:\Users\dblock\Source\GitHub\msiext\dblock\src\WixExtensions\SystemToolsExtension\wixext\WixSystemToolsExtension.csproj.metaproj" (default target)
(67) ->
"C:\Users\dblock\Source\GitHub\msiext\dblock\src\WixExtensions\SystemToolsExtension\wixext\WixSystemToolsExtension.csproj" (default target) (68) ->
(CoreCompile target) ->
  CSC : error CS1566: Error reading resource file 'c:\Users\dblock\Source\GitHub\msiext\dblock\target\Debug\bin\SystemTools.wixlib' -- 'The system ca
nnot find the file specified. ' [C:\Users\dblock\Source\GitHub\msiext\dblock\src\WixExtensions\SystemToolsExtension\wixext\WixSystemToolsExtension.cs
proj]

"C:\Users\dblock\Source\GitHub\msiext\dblock\msi.proj" (build target) (1) ->
"C:\Users\dblock\Source\GitHub\msiext\dblock\Msi.sln" (Build target) (2) ->
"C:\Users\dblock\Source\GitHub\msiext\dblock\src\Demos\DataSourceMsi\DataSourceMsi.wixproj.metaproj" (default target) (73) ->
"C:\Users\dblock\Source\GitHub\msiext\dblock\src\WixExtensions\DataSourceExtension\wixext\WixDataSourceExtension.csproj.metaproj" (default target) (7
4) ->
"C:\Users\dblock\Source\GitHub\msiext\dblock\src\WixExtensions\DataSourceExtension\wixext\WixDataSourceExtension.csproj" (default target) (77) ->
  CSC : error CS1566: Error reading resource file 'c:\Users\dblock\Source\GitHub\msiext\dblock\target\Debug\bin\DataSource.wixlib' -- 'The system can
not find the file specified. ' [C:\Users\dblock\Source\GitHub\msiext\dblock\src\WixExtensions\DataSourceExtension\wixext\WixDataSourceExtension.cspro
j]

"C:\Users\dblock\Source\GitHub\msiext\dblock\msi.proj" (build target) (1) ->
"C:\Users\dblock\Source\GitHub\msiext\dblock\Msi.sln" (Build target) (2) ->
"C:\Users\dblock\Source\GitHub\msiext\dblock\src\WixExtensions\JavaToolsExtension\wixext\WixJavaToolsExtension.csproj.metaproj" (default target) (89)
 -> "C:\Users\dblock\Source\GitHub\msiext\dblock\src\WixExtensions\JavaToolsExtension\wixext\WixJavaToolsExtension.csproj" (default target) (90) ->
  CSC : error CS1566: Error reading resource file 'c:\Users\dblock\Source\GitHub\msiext\dblock\target\Debug\bin\JavaTools.wixlib' -- 'The system cann
ot find the file specified. ' [C:\Users\dblock\Source\GitHub\msiext\dblock\src\WixExtensions\JavaToolsExtension\wixext\WixJavaToolsExtension.csproj]
dblock commented 11 years ago

The only unit test that fails in Release is SysteToolsUnitTest, haven't debugged it yet, but this one seems to cause an AV, sometimes: AppSecInc::UnitTests::Win32::ComImplUnitTests::Test_Win32_GenerateGuidString. It's likely something that has been in the code for a while.

dblock commented 11 years ago

I am merging this, thank you very much, nice job. Can you please take a look at the debug build failure? Thx.

thcristo commented 11 years ago

Hi,

I cannot reproduce the debug build failure. I double checked by fetching the code from your master branch in a new local directory. When I run the command "build all" from a command line window, everything builds OK. I can also build the solution from inside VS2010 with "Build Solution" command. The only thing I can think of is a possible difference in machine configuration like version of Wix installed or a VS2010 setup issue.