search

dblock / msiext

AppSecInc. Community MSI Extensions
Eclipse Public License 1.0
85 stars 109 forks source link

Adding ExecuteOnReinstall attribute for SystemTools - TemplateFile #21

Closed wojwal closed 9 years ago

wojwal commented 9 years ago

Hi there ;)

I needed this feature - in case of same MSI reinstallation or repair - my template file was not changed.

Now it's working fine - I tested it... Pls merge the changes. Thanks ;)

dblock commented 9 years ago

It's good. It needs a CHANGELOG entry please (via --amend, squashed), fix the tab/space thing. See i you can write a test for this one, too, but I would merge it without.

wojwal commented 9 years ago

Ok - fixed the tabs and added changelog...

dblock commented 9 years ago

Could you squash these commits please?

wojwal commented 9 years ago

Done... But pls hold with merging for a while... I want to check sth...

dblock commented 9 years ago

Alright, holding.

wojwal commented 9 years ago

Nope - all is fine - you can merge...

I had another issue - the file path I am templating need to have double slashes (and I'm using [INSTALLDIR] in WiX). But it seems the author of the project I'm working on just modified msiext for double slashes and made custom build. So now when I build from master branch it's single slash again.

I may create another pull request shortly that will add "DoubleSlash" option for TemplateFileProperty

dblock commented 9 years ago

DoubleSlash sounds like a hack, doubt it will fly here ;)

dblock commented 9 years ago

Merged, thanks for contributing! I will plan to do a release soon, haven't been using this project in a long time.