search

dblock / msiext

AppSecInc. Community MSI Extensions
Eclipse Public License 1.0
85 stars 109 forks source link

Added Service_GetStatus call - addressed issues mentioned in the previous request #8

Closed vladaver closed 10 years ago

dblock commented 10 years ago

Thx, this is a lot better, minor comments.

dblock commented 10 years ago

This is good, I'll merge with fixing the above.

dblock commented 10 years ago

I mean I'll take care of fixing the above.

vladaver commented 10 years ago

Thanks. Last minute thought - maybe call should be Service_GetState, with output to SERVICE_STATE? (instead of status)

dblock commented 10 years ago

I merged via https://github.com/dblock/msiext/commit/cd27902106fcd4a4a05c5b620ad3dcf239afffab. I think you're right, it should be "State". Want to make another pull request on top?

dblock commented 10 years ago

Closing this one.

dblock commented 10 years ago

Fyi, you'll have to rebase from my master. You should make feature branches in general and keep master of the repo from which you fork in sync with your master. Also read up on squashing, I often use --amend for updating existing pull requests.

dblock commented 10 years ago

I opened #10 for the rename so we don't forget before releasing anything.